yes tenses are important but here I mean the meaningTenses are very important or we wouldn't have them. A complete sentence would still be appreciate, along with the source of your quote – "broke upon" is a little unusual in modern English ... or at least to me.
thanks . then what is the meaning of the sentence? I mean break into smile ?do you mean he started to smile something like that. by the way break into has the same meaning of break upon ?The source doesn't have to be on the Internet – the source is wherever you found it. In this case, "medieval era" tells us a lot about the usage. Even today, we say that someone breaks into a grin ... from the expression they were wearing. So it's not unusual for a person, or a face, to break into a grin or a smile.
Sort of. It means he suddenly smiled, or changed his expression from an unsmiling one to a smiling one. You wouldn't be likely to use this expression if the person was already looking cheerful to start with (at least I wouldn't).do you mean he started to smile something like that.
No. It's a set expression in this context. I think of it as the original facial expression breaking up and becoming a smile.by the way break into has the same meaning of break upon ?